Re: [PATCH v4 0/2] MR2690: mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mfreadwrite/tests/mfplat.c:
> - todo_wine
> - ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> - if (hr != S_OK)
> -
>    return;
> -
> - /* Test GetService. */
> - sink = (void *)0xdeadbeef;
> - hr = IMFSinkWriter_GetServiceForStream(writer, MF_SINK_WRITER_MEDIASINK,
> -
>        &GUID_NULL, &IID_IMFMediaSink, (void **)&sink);
> - todo_wine
> - ok(hr == MF_E_UNSUPPORTED_SERVICE, "Unexpected hr %#lx.\n", hr);
> - todo_wine
> - ok(!sink, "Unexpected pointer %p.\n", sink);
> -
> - IMFSinkWriter_Release(writer);
>
> +}

Later todos are not doing anything, right? Because writer is not created at all. You can remove the comments, they do not add anything. Does it create a tmp.mp4 file on Windows? If it does we need some clean up.