10 Mar
2023
10 Mar
'23
2:21 a.m.
On Thu Mar 9 18:05:24 2023 +0000, **** wrote:
Marvin replied on the mailing list:
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=130422 Your paranoid android. === w7u_2qxl (32 bit report) === kernel32: loader.c:2324: Test failed: wrong tls data 'hello world' at 00C54600 === w7u_adm (32 bit report) === kernel32: loader.c:2324: Test failed: wrong tls data 'hello world' at 00BE4600 === w7u_el (32 bit report) === kernel32: loader.c:2324: Test failed: wrong tls data 'hello world' at 00C546A0 === w7pro64 (64 bit report) === kernel32: loader.c:2324: Test failed: wrong tls data 'hello world' at 0000000000D405F0
This is a regression in the tests when running on Windows 7. That should have been grounds for rejection of the merge request!