Re: [PATCH v3 0/2] MR9094: rometadata: Add stub + tests for IMetaDataTables

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/rometadata/tests/rometadata.c:
> -
>
> +struct type_info
> +{
> - DWORD exp_flags;
> - const char *exp_name;
> - const char *exp_namespace;
>
> +};
> -
>
> +#define TableFromToken(tk) (TypeFromToken(tk) >> 24)
> -
>
> +static void test_MetaDataDispenser_OpenScope(void)
> +{
> - static const struct table_info tables[45] = {
> -
>    {10, 1, 5, -1, "Module"},
> -
>    {6, 10, 3, -1, "TypeRef"},
> -
>    {14, 3, 6, -1, "TypeDef"},

If you use sizeof(struct row_typedef) instead of hard coding 14 here you'll notice that the test will fail. It shows that the row structures should be packed.