Re: [PATCH 0/2] MR265: vkd3d-shader/hlsl: Add some more constant folding operations.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_constant_ops.c:
>  return true;
>
> }
>
> +static bool fold_sqrt(struct hlsl_ctx *ctx, struct hlsl_constant_value *dst, const struct hlsl_type *dst_type,
> -
>    const struct hlsl_ir_constant *src, const struct vkd3d_shader_location *loc)
>
> +{
> - enum hlsl_base_type type = dst_type->base_type;
> - unsigned int k;
> -
> - assert(type == src->node.data_type->base_type);
> -
> - for (k = 0; k < 4; ++k)

Notice that we use `dimx` here since 717cd3f5bbbfdad8e3b3c03485625ac1a95ccf20.