On 8/9/22 08:36, Zhiyi Zhang wrote:
- assert(0);
- return NULL;
- if (!type)
WARN("Failed to get media type! wg_format major type %d.", format->major_type);
- return type; }
Just a suggestion, but you might want to push this out to leaf functions; that allows you to be more specific about the mode of failure (e.g. "unknown video format %#x").
I do think this should be a FIXME, not just a WARN.