Re: [PATCH v2 0/3] MR1550: misc: Fix some invalid frees of wine_get_dos_file_name.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/appwiz.cpl/addons.c:
> -
>    free( cache_dir );
> -
>    HeapFree( GetProcessHeap(), 0, cache_dir );
>    return NULL;
>
> }
>
> size = lstrlenW( cache_dir ) + ARRAY_SIZE(L"\wine") + lstrlenW( addon->file_name ) + 1;
>    if (!(ret = malloc( size * sizeof(WCHAR) )))
>    {
> -
>    free( cache_dir );
> -
>    HeapFree( GetProcessHeap(), 0, cache_dir );
>    return NULL;
> }
>    lstrcpyW( ret, cache_dir );
>    lstrcatW( ret, L"\wine" );
> - free( cache_dir );
> - HeapFree( GetProcessHeap(), 0, cache_dir );

cache_dir currently uses `malloc()` when it's built from WINEHOMEDIR.