Re: [PATCH 0/9] MR538: mshtml: Implement more methods for Elements.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/htmlelem.c:
> - HRESULT hres;
> -
> - TRACE("(%p)->(%s %s %p)\n", This, debugstr_variant(pvarNS), debugstr_w(strAttributeName), AttributeValue);
> -
> - if(V_VT(pvarNS) == VT_EMPTY || V_VT(pvarNS) == VT_NULL)
> -
>    nsAString_InitDepend(&ns_str, NULL);
> - else {
> -
>    hres = variant_to_nsstr(pvarNS, FALSE, &ns_str);
> -
>    if(FAILED(hres))
> -
>        return hres;
> -
>    nsAString_GetData(&ns_str, &ns);
> -
>    if(!ns[0]) {
> -
>        nsAString_Finish(&ns_str);
> -
>        nsAString_InitDepend(&ns_str, NULL);
> -
>    }
> - }

That's not pretty. We should probably just use NULL for VT_EMPTY in variant_to_nsstr.