[PATCH v2 09/14] mshtml: Implement firstChild prop for attributes.

[Gabriel Ivăncescu]

From: Gabriel Ivăncescu

Signed-off-by: Gabriel Ivăncescu 
---
 dlls/mshtml/htmlattr.c  | 7 +++++--
 dlls/mshtml/tests/dom.c | 8 ++++++++
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/dlls/mshtml/htmlattr.c b/dlls/mshtml/htmlattr.c
index 0ce8ae2cfc1..b0b90dcdbe1 100644
--- a/dlls/mshtml/htmlattr.c
+++ b/dlls/mshtml/htmlattr.c
@@ -238,8 +238,11 @@ static HRESULT WINAPI HTMLDOMAttribute2_get_childNodes(IHTMLDOMAttribute2 *iface
 static HRESULT WINAPI HTMLDOMAttribute2_get_firstChild(IHTMLDOMAttribute2 *iface, IHTMLDOMNode **p)
 {
     HTMLDOMAttribute *This = impl_from_IHTMLDOMAttribute2(iface);
-    FIXME("(%p)->(%p)\n", This, p);
-    return E_NOTIMPL;
+
+    TRACE("(%p)->(%p)\n", This, p);
+
+    *p = NULL;
+    return S_OK;
 }

static HRESULT WINAPI HTMLDOMAttribute2_get_lastChild(IHTMLDOMAttribute2 *iface, IHTMLDOMNode **p)
diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index fdcbeb466aa..00ddc44a243 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -10012,6 +10012,10 @@ static void test_attr_node(IHTMLDOMAttribute *test_attr, IHTMLDocument2 *doc)
     ok(hres == S_OK, "get_childNodes failed: %08lx\n", hres);
     ok(!disp, "childNodes != NULL\n");

+    hres = IHTMLDOMAttribute2_get_firstChild(attr, &node);
+    ok(hres == S_OK, "get_firstChild failed: %08lx\n", hres);
+    ok(!node, "firstChild != NULL\n");
+
     bstr = SysAllocString(L"div");
     hres = IHTMLDocument2_createElement(doc, bstr, &elem);
     ok(hres == S_OK, "createElement failed: %08lx\n", hres);
@@ -10033,6 +10037,10 @@ static void test_attr_node(IHTMLDOMAttribute *test_attr, IHTMLDocument2 *doc)
     ok(hres == S_OK, "hasChildNodes failed: %08lx\n", hres);
     ok(vbool == VARIANT_FALSE, "hasChildNodes returned %d\n", vbool);

+    hres = IHTMLDOMAttribute2_get_firstChild(attr, &node);
+    ok(hres == S_OK, "get_firstChild failed: %08lx\n", hres);
+    ok(!node, "firstChild != NULL\n");
+
     IHTMLDOMNode_Release(elem_node);
     IHTMLDOMAttribute2_Release(attr);
 }