Re: [PATCH v2 0/9] MR396: vkd3d-shader/hlsl: Support non-constant offset dereferences, v2, part 1.

[Francisco Casas (＠fcasas)]

On Wed Oct 11 10:37:15 2023 +0000, Giovanni Mascellani wrote:
> Good to cleanup the node, but my feeling is that should be done at the
> same level it is initialized, i.e., inside
> `new_offset_from_path_index()`. To me keeping a consistent convention
> makes it easier to spot problems. Don't know what the others think about
> that. Another good option is to also initialize the block outside of `new_offset_from_path_index()`.

This seems reasonable.

I prefer the latter option since otherwise we would have to call hlsl_block_cleanup() on every place where new_offset_from_path_index() returns NULL.

I added a new patch 2 to the MR, since this is a prevailing issue.