Re: [PATCH v12 0/1] MR8467: conhost: Implement F1 and F3 support for history retrieval.

[eric pouech (＠epo)]

eric pouech (@epo) commented about programs/conhost/conhost.c:
> +{
> - if (console->edit_line.history_index)
> - {
> -
>    struct edit_line *ctx = &console->edit_line;
> -
>    unsigned int index = ctx->history_index - 1;
> -
>    WCHAR *line = console->history[index]->text;
> -
>    unsigned int len = console->history[index]->len / sizeof(WCHAR);
> -
> -
>    if (len > ctx->cursor)
> -
>    {
> -
>        unsigned int ccount = (copycount > 0) ? copycount : len - ctx->cursor;
> -
> -
>        if (ctx->cursor == ctx->len)
> -
>        {
> -
>            /* Clean the screen. */
> -
>            edit_line_delete(console, ctx->cursor, ctx->len);

since ctx->cursor == ctx->len, this does nothing

the rest looks good to me