Re: [PATCH v17 0/7] MR443: tests: Add some tests for effects groups syntax.

[Nikolay Sivov (＠nsivov)]

On Tue Jan  9 23:21:05 2024 +0000, Henri Verbeet wrote:
> > +    /**
> > +     * Binary format used by Direct3D 9/10.x/11 effects profiles.
> > +     * Output is a raw FX section without container. \since 1.10
> > +     */
> > +    VKD3D_SHADER_TARGET_FX,
>
> That \since will need an update.
> > +    else if ((compile_info->target_type == VKD3D_SHADER_TARGET_FX) !=
>
> (profile->type == VKD3D_SHADER_TYPE_EFFECT))
> > - {
> > -
> >    vkd3d_shader_error(message_context, NULL, VKD3D_SHADER_ERROR_HLSL_INCOMPATIBLE_PROFILE,
> > -
> >            "The '%s' target profile is incompatible with the
>
> 'fx' target type.", profile->name);
> > -
> >    return VKD3D_ERROR_INVALID_ARGUMENT;
> > - }
>
> I think the error message here is inaccurate when "target_type" isn't VKD3D_SHADER_TARGET_FX.

Thanks. Both should be addressed now.