On 20-10-22 02:04, Zebediah Figura wrote:
On 10/19/22 22:36, Francisco Casas wrote:
+static bool compatible_data_types(struct hlsl_ctx *ctx, struct hlsl_type *src, struct hlsl_type *dst) +{ + if (src->type <= HLSL_CLASS_LAST_NUMERIC && src->dimx == 1 && dst->dimy == 1 && type_contains_only_numerics(dst)) + return true;
That looks like a copy-paste error; it should be "src->dimy == 1"? Kinda surprised that didn't cause any test failures...
It indeed was! And after I fixed it, some of the tests in the following patches, specifically [pixel shader fail]s involving matrices, were not passing.
So this was one of the weird cases where two bugs even each other out, *sigh*.
I am changing compatible_data_types() in the next version to ensure that these shaders indeed fail.