Re: [PATCH v17 0/2] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/ddraw/device.c:
> +/*
> -
> - DirectD3D vertex buffer helpers
> -
> -
> -
> - For now, it only supports :
> -
> - d3d_device.version == 7
> -
> - primitive_type == D3DPT_TRIANGLEFAN
> -
> - fvf == 0x2c4
> -
> - flags == 0
> -
> - vertex_count >= 3
> -
> -
> -
> - Note : it does transform D3DPT_TRIANGLEFAN into D3DPT_TRIANGLELIST.
> - */
>
> +static int ddraw_buffer_add_d7(IDirect3DDevice7 *iface, D3DPRIMITIVETYPE primitive_type, DWORD fvf, void *vertices, DWORD vertex_count, DWORD flags, UINT stride) {
> - struct d3d_device *device = impl_from_IDirect3DDevice7(iface);
> -
> - if (!TRACE_ON(ddraw_buffer)) return 0;

We avoid hiding things behind flags like this. We want this to be the default behaviour, and I don't see any reason for it not to be.