15 Sep
2022
15 Sep
'22
7:42 p.m.
On Thu Sep 15 18:54:04 2022 +0000, Jacek Caban wrote:
What's wrong with passing the actual type for those events?
Well for several reasons:
1. Since we aren't using Gecko events for them, there's no point in doing that (just extra overhead). 2. I'm not even sure if Gecko supports creating some of them via CreateEvent (since it's deprecated). 3. The rest of the code (i.e. create_message_event, create_storage_event) create a normal "Event" from Gecko for nsevent, so this keeps it symmetrical. That's because their event type is "Event" since we don't use Gecko's.
To be honest I don't see any benefit in creating the actual Gecko nsevent here for them.