Re: [PATCH 0/3] MR2650: mshtml: Implement MediaQueryList listeners.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/omnavigator.c:
> -
>    free(callback);
> - return ref;
>
> +}
> -
>
> +static nsresult NSAPI media_query_list_callback_HandleChange(nsIDOMMediaQueryListListener *iface, nsIDOMMediaQueryList *mql)
> +{
> - struct media_query_list_callback *callback = impl_from_nsIDOMMediaQueryListListener(iface);
> - struct media_query_list *media_query_list = callback->media_query_list;
> - struct media_query_list_listener *listener;
> - VARIANT args[1], v;
> - HRESULT hres;
> -
> - if(!media_query_list)
> -
>    return NS_OK;
> -
> - LIST_FOR_EACH_ENTRY(listener, &media_query_list->listeners, struct media_query_list_listener, entry) {

This is not safe, the list may mutate during call_disp_func.