On Mon Oct 9 16:24:30 2023 +0000, Gabriel Ivăncescu wrote:
I meant that I have patches (and tests, currently some are todo_wine) where the window from jscript is the outer window, not inner window. Hence, they must be affecting the current window already (since they'll go through the outer window), so this patch can't be wrong in this aspect. I was just addressing your concerns about it, because eventually we'll end up there anyway. Of course this patch is a requirement to have consistency there. I'll also get the other stuff referenced from inner window to hold ref to it now that we have the CC (e.g. navigator, constructors, etc).
Again, orphaned windows should not generally affect current window, in which exact case do you think that's not true?
Scripts hosts are terminated when window changes, so it should take care of that aspects. But there are many more aspects of MSHTML than just scripts and current approach ensures that some in-progress operations can't affect it by design. Changing that would need a stronger argument, saying that we can stop releasing some references, so let's stop releasing all references for "consistency" is not really convincing.