Re: [PATCH v4 0/1] MR3546: gdiplus: move pointer calculation outside inner loop for alpha_blend_bmp_pixels

[Esme Povirk (＠madewokherd)]

On Fri Aug 11 18:27:06 2023 +0000, Jeffrey Smith wrote:
> Performance claims do hint at performance testing results.
> Maybe rewording the commit message to avoid direct mention of
> performance would be a bit less loaded:
> `gdiplus: Move pointer calculation to reduce multiplications in alpha_blend_bmp_pixels.`

I think this change can be made without performance testing.

That said, repeatedly calling GdipBitmapGetPixel and GdipBitmapSetPixel is never going to be efficient. This should probably do something like convert_pixels in image.c, including special cases for common format combinations.