On Mon Apr 14 16:29:34 2025 +0000, Jacek Caban wrote:
Sure, but is it the only property like that? If so, we might want to stop using the generic code for its lookup and treat it as a "custom" prop instead. That would allow the generic logic to assume all functions it handles come from prototypes. We might need to introduce some mechanism for "custom" iids anyway, since that could also be required for indexed property accessors. (Not saying this is necessarily the best approach, but it’s an example where knowing the scope could influence the decision.)
Good point and I'm inclined to go that route, but there's one problem right now. XMLHttpRequest is an actual jscript function (which is fine because it matches the tests), but `create` is an external prop. This leads to the crash since a jscript function doesn't have `prop_get` method (HostObject_prop_get rather). Custom prop isn't going to solve this unfortunately.
IMO I think simplest way is to just make `create` a normal jscript prop in this case, especially since it's an exception to the rule. Is that fine?