Zebediah Figura (@zfigura) commented about dlls/ddraw/device.c:
*****************************************************************************/ static void d3d_device_sync_rendertarget(struct d3d_device *device) {
- struct wined3d_rendertarget_view *rtv;
- struct wined3d_rendertarget_view *rtv, *rtv_target, *dsv_target;
These names aren't great. "rtv_target" stands for "render target view target", for one. Better would be "prev_rtv", "rtv", "dsv". That said, I don't think you need to check the previous rtv at all; it's just meant to avoid calling wined3d_device_context_set_rendertarget_views(), but that function already skips doing real work if the rtv didn't change.