Re: [PATCH v2 0/1] MR899: vbscript: Map known HRESULT values into their FACILITY_VBS counterparts.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/vbscript/vbdisp.c:
>  if(hres == DISP_E_EXCEPTION) {
>      clear_ei(&ctx->ei);
>      ctx->ei = ei;
> -
>    if(!ctx->ei.bstrDescription) {
> -
>        ctx->ei.scode = hres = map_hres(ei.scode);
> -
>        if(HRESULT_FACILITY(hres) == FACILITY_VBS) {
> -
>            ctx->ei.bstrDescription = get_vbscript_error_string(hres);
> -
>            if(!ctx->ei.bstrSource) {
> -
>                ctx->ei.bstrSource = get_vbscript_string(VBS_RUNTIME_ERROR);
> -
>            }
> -
>        }
> -
>    }

I think that we could fix the logic in exec_script() instead of of duplicating it here. What do you think about something like https://gitlab.winehq.org/jacek/wine/-/commit/f1ce7f0962cbc9dac7cc5df420d31f... ?