Re: [PATCH v11 0/2] MR2875: shell32: add support for balloon icon copying

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/shell32/systray.c:
>  /* FIXME: if statement only needed because we don't support interprocess
>   * icon handles */
>  if (nid->uFlags & NIF_ICON)
> -
>    GetIconInfo(nid->hIcon, &iconinfo[0]);
> -
> - if ((nid->uFlags & NIF_INFO) && (nid->dwInfoFlags & NIIF_USER))
> -
>    GetIconInfo(nid->hBalloonIcon, &iconinfo[1]);
> -
> - for (unsigned int i = 0; i < 2; i++)

Would be cleaner to use explicit variables for each icon, instead of arrays and loops. You can maybe split some of it into separate helpers beforehand to reduce the diff when adding the balloon icon.