Re: [PATCH v4 0/5] MR4450: winegstreamer: WMA DMO support

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/wg_format.c:
> - if (!gst_structure_get_int(structure, "depth", &depth))
> - {
> -
>    GST_WARNING("Missing \"depth\" value in %" GST_PTR_FORMAT ".", caps);
> -
>    return;
> - }
> - if (!gst_structure_get_int(structure, "channels", &channels))
> - {
> -
>    GST_WARNING("Missing \"channels\" value in %" GST_PTR_FORMAT ".", caps);
> -
>    return;
> - }
> - if (!gst_structure_get_int(structure, "block_align", &block_align))
> - {
> -
>    GST_WARNING("Missing \"block_align\" value in %" GST_PTR_FORMAT ".", caps);
> -
>    return;
> - }
> - if (!(codec_data_value = gst_structure_get_value(structure, "codec_data")) || !(codec_data = gst_value_get_buffer(codec_data_value)))

This line is very long. 3/5 also introduces some very long lines. It'd be nice to wrap these. (In this case please see [1] for the preferred style.)

(There's no fixed limit on line length in Wine, but in general I'd consider splitting at around 100 columns or so, and I'd definitely avoid going past 120 or so.)

[1] https://wiki.winehq.org/Wine_Developer%27s_Guide/Coding_Practice#Preferred_D...