On Fri Nov 25 15:05:35 2022 +0000, Jacek Caban wrote:
My guess that you shouldn't explicitly check it here, but rather try to load it as usual and urlmon+wininet should simply return data immediately if it's cached. For this to work properly with http protocol, we'd need support for that in wininet first. Note that in case for the referenced bug, it's a local file, so http protocol and caching itself is not relevant.
Even with the test itself having the image in http url (and thus http protocol should be used, right?), I see no HttpProtocol_* methods traced from urlmon, and it's just a bunch of URI stuff that's called, but that's it. I don't see where I can tell it to load it immediately.
Not sure how I'm supposed to intercept that to even begin to see what I can change. I do see that wine-gecko has some checks for "same URI" in LoadImage, but they're not used because image element always passes "force" to load it even if it's the same.
But the rest of gecko's code I followed seems to use its own cache, so idk how to go about overriding that…
But since this is kinda of complicated and I'll need more time to analyze and think about it, I'll remove this patch from the MR for now, so the others can get in, at least.