On Wed Sep 6 10:26:36 2023 +0000, Gabriel Ivăncescu wrote:
Ok, this is a bit confusing to me. According to your test, it fails on Windows, because the iface is actually equal (i.e. it *is* the outer window), see: https://testbot.winehq.org/JobDetails.pl?Key=137021 I tried to query for IHTMLWindow2 and so on as well. I know there's a bunch of messed up stuff on native, see `ActiveScript2_AddNamedItem` comment in the tests. But this does look to me like it gives the outer window to scripts? Am I missing something here? BTW the reason it fails on wine (it's todo_wine in the testbot patch above) is because we return the inner window in `GetItemInfo` instead of the outer window. This would be a separate fix/change of course. But still, that means the outer window is given to script engines.
Yeah, I messed up that test, sorry. That's probably fine.