On Sat Jan 7 04:19:14 2023 +0000, Jinoh Kang wrote:
Do we want to use QueryInterface here too? cc/ @insn
In this case, it's not necessary, we are actually only using it as an element, even later it's up-casted to element. If anything, I think the variable should be an element to begin with (this would move the cast from get_element to GetBody, and get rid of this cast), but I don't think it's worth it as a change. Depends how Jacek feels.
BTW I just realized here it's using hres. This is a nitpick, of course, but it should be using a `nsresult nsres` and check for `NS_OK` instead of `S_OK`, it's more correct code (even though it compiles to the same thing).