On Thu Dec 7 18:42:26 2023 +0000, Rémi Bernon wrote:
Looks good to me but would you mind dropping the win32u change? I think it's probably correct but I would be more comfortable if that was fixed separately. I have reasons to believe that win32u window activation code is incorrect and needs fixing, and that could be part of it.
v5: * Drop set foreground window win32u fix.
Would you like me to propose this separately, or do you plan to include a fix along with the activation code changes you mention?
If we don't expect some fix for this to land before the end of year, and since the driver is particularly susceptible to this (due to calling `NtUserSetForegroundWindow` from the separate, dispatch thread), perhaps it would be worth implementing a temporary mitigation for this issue in the Wayland driver. I was thinking of using a driver internal message to set the foreground window from within the proper window thread (I haven't tried it yet).