Re: [PATCH v3 0/6] MR9305: Reject pseudo-handles in NtWaitForMultipleObjects().

[Paul Gofman (＠gofman)]

Paul Gofman (@gofman) commented about dlls/ntdll/unix/sync.c:
>      TRACE( "}, timeout %s\n", debugstr_timeout(timeout) );
>  }
>
> - if ((ret = inproc_wait( count, handles, type, alertable, timeout )) != STATUS_NOT_IMPLEMENTED)
> - /* Reject pseudo-handles up front. These are not valid for multi-object waits. */
> - for (i = 0; i < count; i++)
> {
> -
>    TRACE( "-> %#x\n", ret );
> -
>    return ret;
> -
>    if ((ULONG)(ULONG_PTR)handles[i] >= 0xfffffffa)

just return STATUS_INVALID_HANDLE here I guess, no need to add a label and jump (even if we want to necessarily keep extra trace that is probably best without label and jump in this case).

Also, probably '> 0xfffffffa' as in cache_inproc_sync()? In this specific case I'd probably suggest to add 'static BOOL is_pseudo_handle()' helper and use it here and in cache_inproc_sync(), for clarity.