20 Oct
2023
20 Oct
'23
6:18 p.m.
On Fri Oct 20 01:27:03 2023 +0000, Alfred Agrell wrote:
changed this line in [version 14 of the diff](/wine/wine/-/merge_requests/3938/diffs?diff_id=77657&start_sha=427a6845e25569c161f17775fda175b8e84f8b26#d19138de09a66cf3bcf4e698b2f5c81e9daf14a2_473_476)
Ah, sorry, I managed to misread this line as doing something more hacky than it is. It's a little easier to read written as "stream_time + diff*100 < 0" [and a temp variable to hold diff*100 would probably also help]. We do want to fix that warning if we can.
It's still a bit odd, because IIRC gst_segment_to_running_time() is supposed to just return -1 for positions that are out of bounds. What are the values that quartz is giving us? Are they generated by our sink or the application's sink?