On Wed Nov 16 05:26:40 2022 +0000, Nikolay Sivov wrote:
In addition to the leak you've fixed, I think there is more. I haven't checked Coverity reports for this one, please take a look to see if you can spot any issues with it. I'll submit it separately, your change is not affected by it. [0001-ole32-compositemoniker-Fix-a-possible-leak-of-moniker-.txt](/uploads/dc70c9bbc0ce4ca6f9b584fbe1a29389/0001-ole32-compositemoniker-Fix-a-possible-leak-of-moniker-.txt)
composite_get_(left|right)most also leak on error, but I'm waiting until !1375 is merged to fix them.
Coverity does not report any other memory leaks in CompositeMonikerImpl_CommonPrefixWith, but that just means that you are sharper than Coverity ;-) The patch that you attached definitely fixes another leak and a double free too.