Re: [PATCH 0/3] MR9427: combobox: Adjust MEASUREITEMSTRUCT.itemHeight by 2 instead of 6.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/combo.c:
> +static int test_wm_measureitem_count;
> -
>
> +static LRESULT CALLBACK test_measure_item_wnd_proc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam)
> +{
> - if (msg == WM_MEASUREITEM)
> - {
> -
>    MEASUREITEMSTRUCT *m = (MEASUREITEMSTRUCT *)lparam;
> -
>    unsigned int expected;
> -
> -
>    ++test_wm_measureitem_count;
> -
>    ok(m->CtlType == ODT_COMBOBOX, "got %#x.\n", m->CtlType);
> -
>    ok(m->CtlID == COMBO_ID, "got %u.\n", m->CtlID);
> -
>    expected = get_font_height(GetStockObject(SYSTEM_FONT)) + 2;
> -
>    if (m->itemID == -1)
> -
>    {

It's not important. But you can move "expected = get_font_height(GetStockObject(SYSTEM_FONT)) + 2;" inside the "if (m->itemID == -1)" branch.