On Wed Nov 5 18:12:02 2025 +0000, Rémi Bernon wrote:
Why do we now have to use ARRAYSIZE here? The underscore variant has many more uses (~13k vs ~200), including on unix side code.
First of all, this is your change, so my question is: why do we now have to use `ARRAY_SIZE`?
Historically, there was a large janitorial effort that introduced `ARRAY_SIZE` as a Wine extension and replaced many open-coded cases. My best guess as to why `ARRAYSIZE` (available in the Windows SDK) wasn’t used at the time is simply oversight and that’s where your usage stats come from. The latter was added later for MSVC compatibility, and both have been fine ever since, but if you’re proposing some kind of unification, I’m not in favor of enforcing the non-compatible variant.