Re: [PATCH v13 0/2] MR3504: ntdll: An implementation of SRWLOCK that closer matches Windows'.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/ntdll/sync.c:
> -
>    }
> -
> -
>    read.Ptr = InterlockedCompareExchangePointer(&lock->Ptr, new.Ptr, old.Ptr);
> -
>    if (read.Ptr == old.Ptr)
> -
>        break;
> -
>    old = read;
> - } while (TRUE);
> -
>    if (!wait) return;
> -
>    RtlWaitOnAddress( &u.s->owners, &new.s.owners, sizeof(short), NULL );
> - while (TRUE)
> - {
> -
>    /* waking up the waiter will invalidate the waiter's entry in
> -
>     * the list. */
> -
>    struct srwlock_waiter *next = head->next;
> -
>    InterlockedOr((LONG *)&head->state, SRWLOCK_WAITER_STATE_NOTIFIED);

Does this actually need to be interlocked?

And, if so, we should just define "state" as a LONG type, avoiding the need to cast.