On Thu Nov 23 01:30:54 2023 +0000, Alfred Agrell wrote:
wmvcore:wmvcore is failing; I'm investigating, but it's not entirely clear to me what exactly it's trying to test for, and I think there's a tiny threading issue in current master (I don't think it's causing any actual trouble, but it still makes me nervous), so it's taking a while to figure out. Wise choice to focus on the WMA DMO first, reviewers.
Solved it; had to switch a few tests to todo, hopefully nothing relies on SetReadStreamSamples() not seeking to the start (considering it previously didn't return the expected compressed data, and changing stream format outside stream start being quite implausible, probably a safe assumption).
Also applied all relevant code review remarks I could find in 4450. (Probably plenty of remark-worthy stuff I didn't find, though. Especially the art of commit size eludes me, I'm just guessing.)