Re: [PATCH v4 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/effect.c:
> -
>                                ok( memcmp_ret == 0,
> -
>                                        "Test #%#1.1x type %#1.1x var name %s index %#1.1x: got %#1.1x (bits: %s), expected %#1.1x (bits: %s).\n",
> -
>                                        x,
> -
>                                        test_set_raw_data_values[x].param_type,
> -
>                                        test_set_raw_data_values[x].param_name,
> -
>                                        y,
> -
>                                        *(((unsigned char*)result_buf) + (single_size * y)),
> -
>                                        result_bit_buf,
> -
>                                        *(((unsigned char*)test_set_raw_data_values[x].expected_data) +
> -
>                                                (single_size * y)),
> -
>                                        expected_bit_buf );
> -
>                                break;
> -
>                            default:
> -
>                                /* Should never get here, but gcc complains without a default... */
> -
>                                trace("Test #%#x not performed. Reached dead codepath.\n", x);
> -
>                                break;

You can probably abort or assert here.