On Fri Nov 18 08:02:34 2022 +0000, eric pouech wrote:
@maljaf:
- I didn't look closely at the patch in the first run... calling
SetLastError() is wrong (and will never be checked by callers). 2. I have actually been working on implementing this function (among a partial implementation of another one). What I suggest is that I include your patch in the serie I'm about to send. (removing the offending SetLastError() call) It may be that the actual implementation of SymAddrIncludeInlineTrace will trigger different code paths in the mentionned game so separating stub from implementation will help on bisecting (if ever needed). Submitted as !1438
@epo:
Could you explain why it's wrong? I used past commits as a reference and the stubs that were added had SetLastError(ERROR_CALL_NOT_IMPLEMENTED). Yeah I agree, I don't think apps actually check for it.
Sure, that's fine.
Yeah, that makes sense given what the function is used for.
Thanks for the link, closing this merge request.