On Wed Mar 6 20:30:02 2024 +0000, Connor McAdams wrote:
This is the only comment I'm iffy about, technically this is the `unaligned` rectangle, which is what I had named the argument initially. I felt like `exclude` made more sense WRT functionality, but I've switched back to `unaligned_rect` in the current revision.
Ah yes, I had it backwards. I think in this case I prefer this anyways; `exclude` looked a bit confusing to me, e.g. in ``` if (exclude_rect) *out_rect = *exclude_rect; ``` I agree that, in general, naming arguments by what they do rather than what they are is nicer; this one is kind of the exception. In any case, not a big deal.