Re: [PATCH v4 0/2] MR1618: gdiplus: improve performance of GdipScaleMatrix

[Alex Henrie (＠alexhenrie)]

Alex Henrie (@alexhenrie) commented about dlls/gdiplus/matrix.c:
> - int i, odd;
> -
> - for(i = 0; i < 6; i++){
> -
>    odd = i % 2;
> -
>    temp[i] = left[i - odd] * right[odd] + left[i - odd + 1] * right[odd + 2] +
> -
>              (i >= 4 ? right[odd + 4] : 0.0);
> - }
> - // Unroll loop to optimize execution speed
> - temp[0] = left[0] * right[0] + left[1] * right[2];
> - temp[1] = left[0] * right[1] + left[1] * right[3];
> - temp[2] = left[2] * right[0] + left[3] * right[2];
> - temp[3] = left[2] * right[1] + left[3] * right[3];
> - temp[4] = left[4] * right[0] + left[5] * right[2] +
> -
>            right[4];
> - temp[5] = left[4] * right[1] + left[5] * right[3] +
> -
>            right[5];

There's no reason to split the last two assignments onto two lines each. The lines are nowhere near the 100-character guideline.