25 Apr
2023
25 Apr
'23
5:11 p.m.
On Tue Apr 25 16:45:42 2023 +0000, Gabriel Ivăncescu wrote:
changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/2691/diffs?diff_id=43913&start_sha=83dc0c808fa3ba6e40495e10b1d49ee40bdf76fb#d85ccdf4f69c07c4732da8a94e52860b56cd9c94_1125_1106)
Making our forced collection more aggressive seems reasonable to me, but I'd hope for a better interface for it. Depending on some side effect of otherwise unrelated logging does not look solid. If Gecko doesn't expose needed interface, it shouldn't be too hard to extend Gecko.
Message pumping in destructor would still be a problem. I guess it's a problem only in some specific tests. We could perhaps just pump window messages before destroying the object in problematic tests themselves.