Re: [PATCH 0/5] MR9332: combase: Implement RoOriginateError.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/combase/combase.rc:
> -
> - You should have received a copy of the GNU Lesser General Public
> -
> - License along with this library; if not, write to the Free Software
> -
> - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
> -
> -
> - */
> -
>
> +#include "resource.h"
> -
>
> +#pragma makedep po
> -
>
> +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT
> -
>
> +STRINGTABLE
> +{
> - IDS_FALLBACK_HRESULT_MESSAGE, "The text associated with this error code could not be found.\r\n"
>
> +}

I don't think this is necessary. Keeping English-only message is fine as a fallback. It doesn't help if exception data contains text about failure to populate exception data. Instead I think we should have something like a formatted string with "Error code 'code'".