27 Sep
2023
27 Sep
'23
4:25 p.m.
On Wed Sep 27 07:51:19 2023 +0000, Alexandre Julliard wrote:
I would like to split tests per interface, to avoid huge files.
Current mlang.c test file, already have 2800 lines of code. mlang.c implementation have almost 3800 lines of code. Please don't. Large files are not much of an issue, and splitting by interface will lead to way too many files.
I would say large files can be an issue AND too many files can be an issue, so you have to strike a balance. In the context of wine, 2800 lines isn't so bad. For tests I had thought the value of cohesive test modules might shift that balance (and mlang only has four interfaces so it seemed reasonable in the context of the module), but it's ultimately up to the Owner.