On Wed Mar 1 20:30:49 2023 +0000, Zebediah Figura wrote:
I added a "if GdipPrivateAddFontFile() fails (probably due to the
sharing violation), try again after closing the file handle" so the other tests in that function continue to work on older wine versions. I'm not sure if that is a good thing or not. I think that's unnecessary; we don't and can't account for wine tests being run with older wine.
In this case, it's necessary to account for Wine failing because the test is added before Wine is fixed. In theory, the commits could be combined to avoid this, but I think it's fine as is.