On Tue Feb 6 17:49:40 2024 +0000, Yuxuan Shui wrote:
In general I agree with you. But those stubs are really trivial basically just logging that they have been called. Demanding they are used in tests feels a bit pedantic.
I didn't mean calling every single stub, as you say they indeed do nothing (and are simply there to fill the vtable). But this midi track creation function is still never called, and it's not so much work to simply reorder the changes to have the midi parser first and make it call it when it is added.