27 Jul
2022
27 Jul
'22
6:11 p.m.
On Wed Jul 27 17:37:41 2022 +0000, **** wrote:
Zebediah Figura replied on the mailing list:
On 7/27/22 12:18, Andr�� Zwing (@AndreRH) wrote: > On Wed Jul 27 16:52:37 2022 +0000, **** wrote: >> Zebediah Figura replied on the mailing list: >> \`\`\` >> I guess, although this doesn't seem like a clear improvement to me. >> _______________________________________________ >> wine-gitlab mailing list -- wine-gitlab@winehq.org >> To unsubscribe send an email to wine-gitlab-leave@winehq.org >> \`\`\` > It's more consistent with the rest of the file and IMHO it improves readability and reduces LOC slightly. But I know what you mean. > I guess I don't see this kind of thing as improving readability. When almost none of the function is shared it's easier to parse as a single self-contained unit. That's just my take, though... _______________________________________________ wine-gitlab mailing list -- wine-gitlab@winehq.org To unsubscribe send an email to wine-gitlab-leave@winehq.org
In my opinion having the ifdef inside the function improves readability and is a bit more idiomatic, because you don't have to consider whether the function signature is different based on preprocessor conditions, and you know it's only the implementation that differs.