31 Jan
2024
31 Jan
'24
8:25 p.m.
On Wed Jan 31 20:25:46 2024 +0000, Henri Verbeet wrote:
From 78ecef0ccf024fa728c952c13cf0c885c61b3a6f Mon Sep 17 00:00:00 2001 From: Francisco Casas <fcasas@codeweavers.com> Date: Mon, 29 Jan 2024 20:07:39 -0300 Subject: [PATCH 2/5] tests/shader-runner: Introduce "only" qualifier. When the "only" qualifier is added to a directive, the directive is skipped if the shader->minimum_shader_model is not included in the range. This can be used on the "probe" directives for tests that have different expected results on different shader models, without having to resort to [require] blocks.I think most languages call that "if"? I.e.:
if(sm<6) probe ... if(sm>=6) probe ...Not that I mind doing something different, but I suppose it might make things slightly harder to pick up for someone new to writing .shader_test's. Some possible alternatives:
probe(sm<6) ... probe(sm>=6) ...cond (sm<6) probe ... (sm>=6) probe ...
Okay, I renamed the "only" qualifiers as "if". Hopefully we won't use these too enough to justify having to add conditional blocks.