Re: [PATCH v4 0/6] MR6680: msvcp140: Use current locale to convert path in _Fiopen.

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcr120/tests/msvcr120.c:
> -
>    { "German",   "t\xe4\xcf\xf6\xdf.txt" },
> -
>    { "Turkish",  "t\xd0\xf0\xdd\xde\xfd\xfe.txt" },
> -
>    { "Arabic",   "t\xca\x8c.txt" },
> -
>    { "Japanese", "t\xb8\xd5.txt" },
> -
>    { "Chinese",  "t\x81\x40\xfd\x71.txt" },
> - };
> -
> - for(i=0; i<ARRAY_SIZE(tests); i++) {
> -
>    if(!p_setlocale(LC_ALL, tests[i].loc)) {
> -
>        win_skip("skipping locale %s\n", tests[i].loc);
> -
>        continue;
> -
>    }
> -
> -
>    if(!MultiByteToWideChar(CP_ACP, 0, tests[i].path, -1, wpath, MAX_PATH)) {
> -
>        win_skip("failed to convert %s with locale %s\n", tests[i].path, tests[i].loc);
> -
>        continue;

MultiByteToWideChar should never fail here.
```suggestion:-2+1
        ok(MultiByteToWideChar(CP_ACP, 0, tests[i].path, -1, wpath, MAX_PATH), "MultiByteToWideChar failed: %lx\n", GetLastError());
```