Re: [PATCH v3 0/4] MR741: Cachestub

[Henri Verbeet (＠hverbeet)]

> +static HRESULT STDMETHODCALLTYPE d3d12_device_ShaderCacheControl(ID3D12Device9 *iface,
> +        D3D12_SHADER_CACHE_KIND_FLAGS kinds, D3D12_SHADER_CACHE_CONTROL_FLAGS control)
> +{
> +    FIXME("iface %p, kinds %x control %x stub!\n", iface, kinds, control);
> +
> +    return E_NOTIMPL;
> +}

Could we use "%#x" for printing hexadecimal values, like we do elsewhere?
> +static HRESULT STDMETHODCALLTYPE d3d12_cache_session_SetName(ID3D12ShaderCacheSession *iface,
> +        const WCHAR *name)
> +{
> +    struct d3d12_cache_session *session = impl_from_ID3D12ShaderCacheSession(iface);
> +
> +    FIXME("iface %p, name %s Stub!\n", iface, debugstr_w(name, session->device->wchar_size));
> +
> +    return E_NOTIMPL;
> +}

Lower-case "stub" please, here and in a couple of other places. For d3d12_cache_session_SetName() in particular we could also just implement it the same way we implement it for other non-GPU objects, like e.g. d3d12_command_signature_SetName().
> +static void test_shader_cache(void)
> +{
> +    ID3D12ShaderCacheSession *session, *session2;
> +    D3D12_SHADER_CACHE_SESSION_DESC desc = {0};
> +    ULONG refcount, base_refcount;

It's not a problem as such, but using "unsigned int" instead of ULONG above might avoid some future -Wformat warnings.