I have more changes to the transforms that rely on this though I don't see what difference it makes. This is IMO some trivial refactoring to simplify the code by factoring common logic across clients into a single place, for some of the changes, and improve debugging experience by making traces more useful, for the other parts and I don't understand why we have to argue about if they are worth having.
Ah sorry, I misspoke, 1-5 are definitely an improvement, it's only 6 and moreso 7 I feel lukewarm about. It's not really factoring out that much (and 7 isn't factoring out anything), and it doesn't seem like it's factoring it out into a place that really makes sense (why would this inhere to the transform?)
But if it's useful for some future patches I'm willing to accept it.