Re: [PATCH v2 0/1] MR5040: dmband: Implement getting/setting GUID_BandParam on band tracks.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmband/bandtrack.c:
>  if (IsEqualGUID(type, &GUID_BandParam))
> -
>    FIXME("GUID_BandParam not handled yet\n");
> - {
> -
>    struct band_entry *new_entry = NULL, *entry, *next_entry;
> -
>    DMUS_BAND_PARAM *band_param = param;
> -
>    if (!band_param || !band_param->pBand)
> -
>        return E_POINTER;
> -
>    if (!(new_entry = calloc(1, sizeof(*new_entry))))
> -
>        return E_OUTOFMEMORY;
> -
>    new_entry->band = band_param->pBand;
> -
>    new_entry->head.lBandTimeLogical = time;
> -
>    new_entry->head.lBandTimePhysical = band_param->mtTimePhysical;
> -
>    IDirectMusicBand_AddRef(new_entry->band);
> -
>    if (list_empty(&This->bands))
> -
>            list_add_tail(&This->bands, &new_entry->entry);
> -
>    else

```suggestion:-2+0
        if (list_empty(&This->bands))
            list_add_tail(&This->bands, &new_entry->entry);
        else
```