On Wed Feb 1 20:27:28 2023 +0000, **** wrote:
Marvin replied on the mailing list:
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=129009 Your paranoid android. === w7u_2qxl (32 bit report) === comdlg32: itemdlg: Timeout === w7u_adm (32 bit report) === comdlg32: itemdlg: Timeout === w7u_el (32 bit report) === comdlg32: itemdlg: Timeout === w1064v1507 (32 bit report) === comdlg32: itemdlg: Timeout === w1064v1809 (32 bit report) === comdlg32: itemdlg: Timeout === w1064_tsign (32 bit report) === comdlg32: itemdlg: Timeout === w10pro64 (32 bit report) === comdlg32: itemdlg: Timeout === w1064v1507 (64 bit report) === comdlg32: itemdlg: Timeout === w1064v1809 (64 bit report) === comdlg32: itemdlg: Timeout === w1064_2qxl (64 bit report) === comdlg32: itemdlg: Timeout === w1064_adm (64 bit report) === comdlg32: itemdlg: Timeout === w1064_tsign (64 bit report) === comdlg32: itemdlg: Timeout === w10pro64 (64 bit report) === comdlg32: itemdlg: Timeout === w10pro64_en_AE_u8 (64 bit report) === comdlg32: itemdlg: Timeout === w10pro64_ar (64 bit report) === comdlg32: itemdlg: Timeout === w10pro64_ja (64 bit report) === comdlg32: itemdlg: Timeout === w10pro64_zh_CN (64 bit report) === comdlg32: itemdlg: Timeout
I can't reproduce this on a Windows 10 machine I have direct access to, but [Marvin reproduces reliably](https://testbot.winehq.org/JobDetails.pl?Key=130454&s201=1&f201=exe3...). However, Marvin also reproduces this timeout when using [an almost-unchanged (vs. git master) test](https://testbot.winehq.org/JobDetails.pl?Key=130455&f201=exe32.report#k2...), so it does not appear to be a new failure introduced by this MR.
As far as I can tell, this test fails: `test_filename_opendlg(filename_noextW, psi_current, defextW, NULL, 0, filename_noextW);`. It looks like the call to `hr = IFileOpenDialog_Show(pfod, NULL);` never returns? But Marvin's "final screenshot" shows no open dialog, either.
The last successful thing the test run does appears to be `br = PostMessageW(dlg_hwnd, WM_COMMAND, IDOK, 0);`, which apparently simulates an "OK" button click in the file open dialog. (Google tells me `MAKEWPARAM(IDOK, BN_CLICK)` might be a better second argument, but since the dialog closes according to the Marvin screenshot and it works on my bare-metal Window 10 machine, I'm not sure what's going on?)