Giovanni Mascellani (@giomasce) commented about tests/shader_runner_gl.c:
- struct vkd3d_shader_combined_resource_sampler *combined_samplers;
- unsigned int combined_sampler_count;
+};
+static struct gl_runner *gl_runner(struct shader_runner *r) +{
- return CONTAINING_RECORD(r, struct gl_runner, r);
+}
+static void debug_output(GLenum source, GLenum type, GLuint id, GLenum severity,
GLsizei length, const GLchar *message, const void *userParam)+{
- if (message[length - 1] == '\n')
--length;- trace("%.*s\n", length, message);
This is a bit annoyingly chatty, at least on my setup. It prints a lot of messages like: ``` shader_runner_gl:82: Section [test], line 40: Shader Stats: SGPRS: 32 VGPRS: 16 Code Size: 200 LDS: 0 Scratch: 0 Max Waves: 20 Spilled SGPRs: 0 Spilled VGPRs: 0 PrivMem VGPRs: 0 Outputs: 0 PatchOutputs: 0 DivergentLoop: 0 InlineUniforms: 0 (VS, W32) shader_runner_gl:82: Section [test], line 40: Shader Stats: SGPRS: 8 VGPRS: 8 Code Size: 60 LDS: 0 Scratch: 0 Max Waves: 20 Spilled SGPRs: 0 Spilled VGPRs: 0 PrivMem VGPRs: 0 Outputs: 1 PatchOutputs: 0 DivergentLoop: 0 InlineUniforms: 0 (PS, W32) ```
That's s bit more than what I consider sensible for a default verbosity level. Could that be reduced?